Skip to content

chore: cleanup - #197

Merged
alexghr merged 1 commit into
stack/refactor-metric-labelsfrom
stack/chore-cleanup
Sep 15, 2026
Merged

alexghr merged 1 commit into
stack/refactor-metric-labelsfrom
stack/chore-cleanup

Conversation

@alexghr

@alexghr alexghr commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Fix A-2040

@alexghr
alexghr added this pull request to stack #198 September 14, 2026 14:01
@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The infrastructure cleanup appears safe to merge, with a non-blocking documentation mismatch for the retired RPC endpoints.

Findings

  1. P2 Retired endpoints remain documented

Summary

  • Leaves only the canonical/v5 RPC deployments and image configuration.
  • Updates the deploy-rpc README for the canonical-only configuration.
  • Removes redundant fisherman settings after scaling the deployment to zero.
  • The removed RPC hostnames remain advertised in an operational guide and should be retired there as well.

Reviews (1) · Last reviewed commit: "chore: cleanup"

@@ -62,14 +62,6 @@ locals {
ROLLUP_VERSION = ""

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Retired endpoints remain documented

Removing the v4 RPC entries also removes their backends, routes, certificates, and managed DNS hosts. However, the RPC operations guide still advertises v4.testnet.rpc.aztec-labs.com, testnet.rpc.aztec-labs.com, and v4.mainnet.rpc.aztec-labs.com as available endpoints. Operators following that guide will send requests to endpoints this Terraform configuration no longer provisions, so the references should be retired or redirected as part of this decommission. The same issue applies to the corresponding removal in spartan/terraform/deploy-rpc/environments/mainnet/main.tf:62.

@spalladino spalladino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we have metrics on whether anyone is hitting the v4 rpc?

@alexghr
alexghr force-pushed the stack/chore-cleanup branch from 24c2d61 to 4474ab0 Compare September 15, 2026 15:46
@alexghr
alexghr force-pushed the stack/chore-cleanup branch from 4474ab0 to 78906e2 Compare September 15, 2026 16:23
@alexghr
alexghr merged commit 3c400fe into main Sep 15, 2026
8 of 9 checks passed
@alexghr
alexghr deleted the stack/chore-cleanup branch September 15, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants