Use transparent logo in header + favicon#46
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TDD evidence
npx playwright test e2e/feed.spec.ts --grep "verified feed" --project=chromium-desktopfailed because the mark still measured 24pxVerification
npm run lintnpm run typechecknpm run test:unit(311 passed, 6 skipped)npm run test:e2e(36 passed, 2 skipped)/,/analyze, and/feed/feed-item-treasury-billsreturned the shared decorative header mark/icon.pngbyte-matchessrc/app/icon.png; nofavicon.icois presentManual QA note
The in-app browser backend was unavailable in this environment, so interactive tab-level visual inspection could not be completed. Real desktop/mobile Chromium coverage, direct rendered-route inspection, and PNG alpha/icon-response checks passed.