Skip to content

feat: Playerbot methods & support #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iThorgrim wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: Playerbot methods & support #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e847f2
feat: adding some Playerbot methods
iThorgrim Aug 28, 2026
41e8da5
feat: add PlayerbotFactoryMethods, PlayerbotMgrMethods, PlayerbotHold…
iThorgrim Aug 28, 2026
cf16da0
feat: add new methods & fixes
iThorgrim Aug 28, 2026
e7523ef
fix: remove dead (legacy) method
iThorgrim Aug 28, 2026
748f502
fix: remove log & print related method
iThorgrim Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/LuaEngine/ALETemplate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ extern "C"
#include "ALECompat.h"
#include "ALEUtility.h"
#include "SharedDefines.h"
#include <type_traits>

class ALEGlobal
{
Expand Down Expand Up @@ -347,8 +348,13 @@ class ALETemplate
{
// Get object pointer (and check type, no error)
ALEObject* obj = ALE::CHECKOBJ<ALEObject>(L, 1, false);
if (obj && manageMemory)
delete static_cast<T*>(obj->GetObj());
// Types whose destructor is not accessible, singletons for example, can never be
// memory managed by ALE, so the delete must not even be compiled for them.
if constexpr (std::is_destructible_v<T>)
{
if (obj && manageMemory)
delete static_cast<T*>(obj->GetObj());
}
delete obj;
return 0;
}
Expand Down
334 changes: 334 additions & 0 deletions src/LuaEngine/LuaFunctions.cpp
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading