Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the standard AZ Navbar Twig template to mirror the upstream Arizona Bootstrap accessibility fix for vertical-rule list separators.
Changes:
- Moves
aria-hidden="true"from the separator<span>to the wrapping<li>. - Removes
role="presentation"from the separator list item to preserve valid list semantics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Tugboat has finished building the preview for this pull request! Link: Dashboard: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjusts the template file for AZ Navbar to mirror the accessibility fix introduced with AZBS#2029.
Release notes
Related issues
AZQS#5661, AZBS#2029
How to test
<li class="nav-item" role="presentation"><span class="vr" aria-hidden="true></span></li>exist in the HTML markup of AZ Navbar.Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist