Skip to content

Fixes #5661: AZ Navbar list element accessibility error#5662

Open
djcelaya wants to merge 1 commit into
mainfrom
bug/5661
Open

Fixes #5661: AZ Navbar list element accessibility error#5662
djcelaya wants to merge 1 commit into
mainfrom
bug/5661

Conversation

@djcelaya
Copy link
Copy Markdown
Contributor

@djcelaya djcelaya commented May 29, 2026

Description

Adjusts the template file for AZ Navbar to mirror the accessibility fix introduced with AZBS#2029.

Release notes

Related issues

AZQS#5661, AZBS#2029

How to test

  1. Enable AZ Navbar.
  2. Confirm that no instances of <li class="nav-item" role="presentation"><span class="vr" aria-hidden="true></span></li> exist in the HTML markup of AZ Navbar.
  3. Verify with accessibility checkers as needed.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@djcelaya djcelaya linked an issue May 29, 2026 that may be closed by this pull request
@djcelaya djcelaya self-assigned this May 29, 2026
@djcelaya djcelaya added accessibility 3.4.x only bug Something isn't working labels May 29, 2026
@djcelaya djcelaya moved this from Todo to In Progress in 3.4.1 bug-fix patch release May 29, 2026
@djcelaya djcelaya marked this pull request as ready for review May 29, 2026 23:04
@djcelaya djcelaya requested review from a team as code owners May 29, 2026 23:04
Copilot AI review requested due to automatic review settings May 29, 2026 23:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the standard AZ Navbar Twig template to mirror the upstream Arizona Bootstrap accessibility fix for vertical-rule list separators.

Changes:

  • Moves aria-hidden="true" from the separator <span> to the wrapping <li>.
  • Removes role="presentation" from the separator list item to preserve valid list semantics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@djcelaya djcelaya moved this from In Progress to Needs review in 3.4.1 bug-fix patch release May 29, 2026
@djcelaya djcelaya requested a review from accesswatch May 29, 2026 23:07
@az-digital-bot
Copy link
Copy Markdown
Contributor

Tugboat has finished building the preview for this pull request!

Link:

Dashboard:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.4.x only accessibility bug Something isn't working

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

AZ Navbar list element accessibility error

3 participants