Fix(login-register): hide the 'or' divider on register when no SSO is enabled - #83
Fix(login-register): hide the 'or' divider on register when no SSO is enabled#83Musicminion wants to merge 1 commit into
Conversation
… configured The ldap/saml/oidc buttons are each guarded by an if, but the 'or' separator above them was rendered unconditionally, so it showed on a plain email-only register page (issue #77). Guard it with the same condition already used in login.pug.
|
@codex, code reivew |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Try to hide local login when OICD is enabled pls. |
This might be a bit tricky. For example, if the admin initially registered through the launchpad using a username and password, hiding the local login once OIDC is enabled could prevent the admin from logging in at all. Of course, the admin could potentially link their account to OAuth/OIDC first, but in that case I’m not sure hiding the local login provides much practical benefit. |
2 participants
Description
The ldap/saml/oidc buttons are each guarded by an if, but the 'or' separator above them was rendered unconditionally, so it showed on a plain email-only register page (issue #77). Guard it with the same condition already used in login.pug.
Related issues / Pull Requests
Contributor Agreement