Remediate review-of-review findings (thoth-l0n, thoth-hai, thoth-hu3, thoth-4or, thoth-0x0, thoth-6rt, thoth-v2j) - #3
Open
axAilotl wants to merge 5 commits into
Open
Remediate review-of-review findings (thoth-l0n, thoth-hai, thoth-hu3, thoth-4or, thoth-0x0, thoth-6rt, thoth-v2j)#3axAilotl wants to merge 5 commits into
axAilotl wants to merge 5 commits into
Conversation
…retention skips (thoth-6rt, thoth-v2j, thoth-hu3)
…nd 'fix/review-followups-s3' into fix/review-followups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up remediation from the review of the thoth-7v1 fix epic (PR #1 post-merge review). Three parallel streams, merged octopus; full suite green: 410 passed, 2 skipped.
artifact_typessilent default now logs a loud warning naming the skill and resolved scope (fallback kept for compat, no longer silent)map_boundedlogs every collected worker error before raising the first_validate_status_transitioncall; collapsed three copy-pasted artifact-review methods into one helperINquery (was N+1)datetime.now()writers routed throughcore/time_utilsUTC helpers (ingestion_runtime,research_graph,archivist_state,metadata_db,wiki_scaffold); added naive→UTC coercion at the archivist due-date comparison for legacy persisted state_first_present_value/_group_by_optional_attrconsolidated into newcore/collection_utils.py;_WIKI_DOCUMENT_CACHEbounded at 1024 entries with oldest-first evictionNot included: thoth-13k (evidence-free promotion policy) — a product decision, filed separately for the operator.
Test plan
PYTHONPATH=. .venv/bin/python -m pytest tests -q -x --ignore=tests/test_archivist_benchmark.py→ 410 passed, 2 skippedpython3 -m compileall -q core collectors processors thoth.py thoth_api.py tests