Skip to content

[FEATURE] Add S3 doc-store option to WikiHow extraction benchmark #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noel-improv wants to merge 2 commits into
base: main
Choose a base branch
from
+34 −4
Open

[FEATURE] Add S3 doc-store option to WikiHow extraction benchmark #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b121c5
feat(integration-tests): add S3 doc-store option to WikiHow extractio…
noel-improv Jul 22, 2026
7042904
fix(integration-tests): validate S3 env vars before S3 doc-store benc…
noel-improv Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions integration-tests/build-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,12 @@ fi
if [[ "$BENCHMARK_IS_PROTOTYPE" ]]; then
echo "export BENCHMARK_IS_PROTOTYPE=$BENCHMARK_IS_PROTOTYPE" >> lexical-graph-examples/.env.testing
fi
if [[ "$BENCHMARK_DOC_STORE" ]]; then
echo "export BENCHMARK_DOC_STORE=$BENCHMARK_DOC_STORE" >> lexical-graph-examples/.env.testing
fi
if [[ "$BENCHMARK_S3_JSONL" ]]; then
echo "export BENCHMARK_S3_JSONL=$BENCHMARK_S3_JSONL" >> lexical-graph-examples/.env.testing
fi

zip -r graphrag-toolkit.zip graphrag-toolkit # zip under directory

Expand Down
32 changes: 28 additions & 4 deletions integration-tests/test-scripts/graphrag_toolkit_tests/benchmark_extract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from graphrag_toolkit.lexical_graph.storage import GraphStoreFactory
from graphrag_toolkit.lexical_graph.storage import VectorStoreFactory
from graphrag_toolkit.lexical_graph.storage.graph import NonRedactedGraphQueryLogFormatting
from graphrag_toolkit.lexical_graph.indexing.load import FileBasedDocs
from graphrag_toolkit.lexical_graph.indexing.load import FileBasedDocs, S3BasedDocs
from graphrag_toolkit.lexical_graph.indexing.extract import BatchConfig

from llama_index.core import SimpleDirectoryReader
Expand Down Expand Up @@ -69,9 +69,33 @@ def run_benchmark_extract(handler: IntegrationTestHandler,
)
indexing_config = IndexingConfig(batch_config=batch_config)

extracted_docs = FileBasedDocs(
docs_directory=os.path.join(data_dir, dataset_name, 'extracted'),
collection_id=dataset_name
doc_store = os.environ.get('BENCHMARK_DOC_STORE', 'file').lower()
if doc_store == 's3':
missing = [
var for var in ('AWS_REGION_NAME', 'S3_RESULTS_BUCKET', 'S3_RESULTS_PREFIX')
if not os.environ.get(var)
]
if missing:
raise ValueError(
f"BENCHMARK_DOC_STORE=s3 requires {', '.join(missing)} to be set"
)
extracted_docs = S3BasedDocs(
region=os.environ['AWS_REGION_NAME'],
bucket_name=os.environ['S3_RESULTS_BUCKET'],
key_prefix=f'{os.environ["S3_RESULTS_PREFIX"]}/doc-store/{dataset_name}',
collection_id=None,
for_jsonl=os.environ.get('BENCHMARK_S3_JSONL', 'false').lower() == 'true'
)
else:
extracted_docs = FileBasedDocs(
docs_directory=os.path.join(data_dir, dataset_name, 'extracted'),
collection_id=dataset_name
)

logger.info(
f'Doc store: {type(extracted_docs).__name__} '
f'(for_jsonl={getattr(extracted_docs, "for_jsonl", "n/a")}) '
f'collection_id={extracted_docs.collection_id}'
)

with (
Expand Down