Separate benchmark pipeline into dedicated top-level directory - #417
Separate benchmark pipeline into dedicated top-level directory#417oussamahansal wants to merge 2 commits into
Conversation
mykola-pereyma
left a comment
There was a problem hiding this comment.
Few questions:
-
Copy drift risk —
integration_test_base.pyandintegration_test_handler.pyare copied intobenchmarks/scripts/with a canonical-source header. If the canonical source inintegration-tests/changes, the benchmark copy goes stale silently. Would a symlink, a shared internal package, or a direct import from the integration-tests path work instead? -
Ordering with PR #416 — Both PRs modify the same benchmark files (
retriever_factory.py,benchmark_query.py). Whichever merges second will have conflicts. Which should land first, and should the other be rebased on top? -
How to run benchmarks from new location — The README should document the new invocation path. How does
test_suite.pyrouting work with the newbenchmarks.*module paths? A contributor looking atbenchmarks/for the first time would not know how to run them.
|
Description
Separate benchmark pipeline into dedicated top-level
benchmarks/directoryChanges
benchmark_build.py, benchmark_query.py, benchmark_evaluate.py, benchmark_extract.py) fromintegration-tests/test-scripts/graphrag_toolkit_tests/tobenchmarks/scripts/run_evaluation.py, retriever_factory.py, token_tracker.py,etc.) fromintegration-tests/test-scripts/graphrag_toolkit_tests/benchmark_utils/tobenchmarks/utils/benchmarks/datasets/benchmarks/tests/integration_test_base.py, integration_test_handler.py) intobenchmarks/scripts/with canonical-source headersbenchmark-tests/directoryProblem
Benchmark pipeline code was interleaved with integration test infrastructure, making it difficult to run benchmarks independently, onboard new datasets, or understand which files belonged to which workflow.
Related issue (if any): #
Testing
pytest)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.