Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sagemaker-core/src/sagemaker/core/utils/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -538,9 +538,11 @@ def _serialize_dict(value: Dict) -> dict:
dict: The serialized dict
"""
serialized_dict = {}
# Drop only Unassigned/None; preserve valid falsy values like False, 0, "".
for k, v in value.items():
if serialize_result := serialize(v):
serialized_dict.update({k: serialize_result})
serialize_result = serialize(v)
if serialize_result is not None:
serialized_dict[k] = serialize_result
return serialized_dict


Expand All @@ -555,8 +557,10 @@ def _serialize_list(value: List) -> list:
list: The serialized list
"""
serialized_list = []
# Drop only Unassigned/None; preserve valid falsy values like False, 0, "".
for v in value:
if serialize_result := serialize(v):
serialize_result = serialize(v)
if serialize_result is not None:
serialized_list.append(serialize_result)
return serialized_list

Expand Down
14 changes: 14 additions & 0 deletions sagemaker-core/tests/unit/generated/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,20 @@ def test_serialize_method_returns_correct_data():
assert serialized_data["S3Uri"] == "s3/uri"


def test_serialize_preserves_falsy_dict_values():
# Regression: previously False / 0 / "" were stripped along with None.
assert serialize({"k": False}) == {"k": False}
assert serialize({"k": 0}) == {"k": 0}
assert serialize({"k": ""}) == {"k": ""}
assert serialize({"k": None}) == {}
assert serialize({"k": Unassigned()}) == {}


def test_serialize_preserves_falsy_list_values():
assert serialize([False, 0, ""]) == [False, 0, ""]
assert serialize([None, "x", Unassigned(), 1]) == ["x", 1]


def test_serialize_method_nested_shape():
trial_component_parameters = {
"test_num_value": TrialComponentParameterValue(number_value=1),
Expand Down
Loading