feat: expose poll interval parameter on all trainers#5859
Draft
joshuatowner wants to merge 1 commit into
Draft
Conversation
joshuatowner
requested a deployment
to
manual-approval
GitHub Actions
Waiting
joshuatowner
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose poll interval parameter on trainer train() methods
Adds a poll parameter (default 5s) to train() on SFTTrainer, DPOTrainer, RLVRTrainer, and RLAIFTrainer. This passes through to the underlying trainer_wait.wait() function, which already accepts poll but had no way to configure it from the trainer API.
Allows callers to control how frequently the SDK polls for training job status updates during wait=True.
trainer.train(wait=True, poll=30) # poll every 30s instead of default 5s
Testing