Fix VolumeSizeInGB missing from v3 deploy for models with inference_v…#5847
Open
lhnealreilly wants to merge 4 commits into
Open
Fix VolumeSizeInGB missing from v3 deploy for models with inference_v…#5847lhnealreilly wants to merge 4 commits into
lhnealreilly wants to merge 4 commits into
Conversation
…olume_size from_jumpstart_config() retrieves deploy kwargs (which includes volume_size) but never persisted it on the ModelBuilder instance. Then _deploy_core_endpoint read volume_size from kwargs with no self.* fallback, so it was always None. Two-line fix in model_builder.py: 1. from_jumpstart_config(): persist volume_size from deploy_kwargs (same as model_data_download_timeout and container_startup_health_check_timeout) 2. _deploy_core_endpoint(): fall back to self.volume_size when not in kwargs Same pattern as EnableNetworkIsolation fix in v3.10.1.
evakravi
previously approved these changes
May 12, 2026
jam-jee
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…olume_size
from_jumpstart_config() retrieves deploy kwargs (which includes volume_size) but never persisted it on the ModelBuilder instance. Then _deploy_core_endpoint read volume_size from kwargs with no self.* fallback, so it was always None.
Two-line fix in model_builder.py:
Same pattern as EnableNetworkIsolation fix in v3.10.1.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.