Make version a required input, keep derivation as advisory#16
Merged
Conversation
Version selection is a business decision. The operator now explicitly provides the release version string. The derivation script remains as a local helper tool for suggesting the next version. - Rename version_override to version (required) - Validate format: X.Y.ZamznN.N or X.Y.Z (OFIWG passthrough) - Warn if input differs from derivation suggestion - OFIWG detection: check absence of 'amzn' in version string
shijin-aws
reviewed
May 20, 2026
| echo "::debug::Derived version=${RELEASE_VERSION} tag=${TAG}" | ||
| if [ -n "${SUGGESTED}" ] && [ "${SUGGESTED}" != "${RELEASE_VERSION}" ]; then | ||
| ANNOTATION_LOG=$(echo "${DERIVATION_LOG}" | sed 's/$/%0A/' | tr -d '\n') | ||
| echo "::warning title=Specified version differs from derived suggestion::Specified version: ${RELEASE_VERSION}%0ADerived suggestion: ${SUGGESTED}%0A%0A${ANNOTATION_LOG}" |
Member
Author
There was a problem hiding this comment.
No. Version specification is a business-owned decision (i.e. manual process). The version derivation logic is "best effort" and should catch most mistakes, but it should be purely advisory. We also can't treat something like this as infallible. Maybe if our version format followed a standard like SemVer.
Failing here would be very disruptive in some scenarios and would require an extra "force" parameter of some kind.
shijin-aws
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the GHA workflow's ability to determine the version string on its own.
If the specified version string differs from the logic defined in the derivation script, a warning annotation is logged.
See test workflow here: https://github.com/darrylabbate/aws-libfabric/actions/runs/26064754139