Add tooltips and refine clickable schema type affordances#1860
Open
kmcginnes wants to merge 1 commit into
Open
Add tooltips and refine clickable schema type affordances#1860kmcginnes wants to merge 1 commit into
kmcginnes wants to merge 1 commit into
Conversation
Explain the click action with a tooltip on hover or keyboard focus, give edge types a hover underline so they read as interactive, and fix the edge button accessible name to drop the decorative arrows. Extract a shared ClickableTypeText primitive and a toSelectedElements helper alongside toSchemaGraphSelection, and align the focus ring with the rest of the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up polish on the clickable node/edge types in the Schema Explorer details panel (shipped in #1731). Makes the click affordance discoverable and explains what it does:
ring-ring-3/outline-hidden).→arrow separators are nowaria-hiddensiblings, so each type button's accessible name is just its label (e.g. "knows", not "→ knows →").Supporting refactor (no behavior change): extracted a shared
ClickableTypeTextprimitive to remove the duplicated button-vs-span branches, and atoSelectedElementshelper alongside the existingtoSchemaGraphSelectionso both selection-mapping directions live together.How to read
ClickableTypeTextprimitive, tooltip, hover/focus styling, selected-type span, andaria-hiddenseparatorstoSelectedElementshelper next totoSchemaGraphSelectiontoSelectedElementsValidation
node_modules/.bin/vitest run packages/graph-explorer/src/modules/SchemaGraph— 22 tests pass, including new coverage for the selected-type-not-clickable behavior, the clean accessible name, the focus tooltip, and thetoSelectedElementsmapping.tsc --noEmit,oxlint, andoxfmt --checkclean on the changed files.Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.