Add paging to the icon picker#1819
Merged
Merged
Conversation
Replace the icon picker's hard 64-icon cap and "type to search" hint with paging through the full icon list. Adds a minimal footer (Page X of Y plus prev/next chevrons) modeled on the query results list, 64 icons per page. Page position persists while the style dialog stays open and resets on search or when the dialog reopens.
Replace the native title attribute on each icon button with the Button tooltip prop, giving a styled tooltip and an aria-label accessible name. Tests identify icon buttons by aria-pressed and read names from aria-label, and wrap renders in TooltipProvider as the app does.
The autoUpdate ratchet bumped the function threshold to 60 from a local coverage measurement, but CI measures 58.47% functions and fails. Revert the function floor to 58 (its pre-paging value); statements, branches, and lines stay at the ratcheted values, which CI still meets.
arseny-kostenko
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The icon picker (added in #1777) capped the grid at 64 icons and told users to "type to search" — there was no way to browse the rest of the Lucide library. This adds paging so every icon is reachable.
Page X of Y+ prev/next chevrons) modeled on the query results list footer.filterIconsreturns the full match list instead of stopping at a hard cap.Buttontooltipprop instead of the nativetitle, giving a styled tooltip and anaria-labelaccessible name.Suggested reading order:
IconPicker.tsx(component + newPagerFooter), thenIconPicker.test.tsx.Validation
pnpm checkspasses (lint, format, types)pnpm testpasses (1787 tests;IconPicker.tsxat 100% line coverage)The
vitest.config.tschange is the repo's automatic coverage-threshold ratchet, not a hand edit.Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.