fix(ci): rubocop Style/DirectiveScope and json pretty_unparse removal - #166
Merged
Merged
Conversation
Recent rubocop and json gem releases broke CI on main. rubocop 1.90 added Style/DirectiveScope which flags the Style/RedundantSelf disable/enable pair in configure_client. Dropped the pair and switched self.superclass to superclass. json 3.0.0 removed JSON.pretty_unparse. Swapped the two call sites in transactions.rb to JSON.pretty_generate. Runtime behavior unchanged in both cases. record.rb#table_name has the same pattern but rubocop isn't flagging it, so leaving that one alone for now.
jterapin
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Recent rubocop and json gem releases broke CI on main.
Style/DirectiveScope, which flags theStyle/RedundantSelfdisable/enable pair inconfigure_client. Dropped the pair and switchedself.superclasstosuperclass(self.classkept, reserved-keyword conflict). Runtime behavior unchanged.JSON.pretty_unparse. Swapped the two call sites intransactions.rbtoJSON.pretty_generate(always was an alias for it; runtime behavior unchanged).Local verification:
bundle exec rake release:test→ 372/0,bundle exec rubocop -E -S→ 0 offenses,gem build aws-record.gemspec→ success.Note:
record.rb#table_namehas the sameself.superclass + rubocop:disable Style/RedundantSelfpattern, but rubocop isn't flagging it today. Leaving as-is; will revisit if a future rubocop release surfaces it.Drafted with AI assistance; reviewed and tested locally.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.