fix(release): source test vector values from one file so npm 12 can run scripts#1683
Merged
Conversation
npm 12 rejects the package.json 'config' keys as unknown config, breaking every 'npm run'. Inline the four values into the scripts and drop the block.
1 task
There was a problem hiding this comment.
Pull request overview
This PR updates the root package.json npm scripts to avoid relying on package.json’s config block and $npm_package_config_* expansion, which breaks under npm 12 (EUNKNOWNCONFIG) and causes npm run build to fail in publishing workflows.
Changes:
- Inlines four previously-configured integration constants (test vector zip path, encrypt manifest URL, key manifest URL, decrypt oracle URL) directly into the scripts that consume them.
- Removes the
configblock frompackage.jsonto prevent npm 12 from erroring on unknown config keys.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace the inlined values with a single util/integration-test-vectors.sh that the integration-* and verdaccio-* scripts source.
lucasmcdonald3
changed the title
added 2 commits
July 22, 2026 15:27
Chain with && so a failed build stops the script, and quote the variable expansions so paths with spaces work.
sharmabikram
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
npm 12 removed support for the config block (for some reason). Put them into a shell file, then use them in CI targets.
These variables are used in CI targets for this PR so this PR validates these work.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: