Skip to content

fix(release): drop --unsafe-perm from publish npm ci#1682

Merged
lucasmcdonald3 merged 5 commits into
masterfrom
fix-master-publish-unsafe-perm
Jul 23, 2026
Merged

fix(release): drop --unsafe-perm from publish npm ci#1682
lucasmcdonald3 merged 5 commits into
masterfrom
fix-master-publish-unsafe-perm

Conversation

@lucasmcdonald3

@lucasmcdonald3 lucasmcdonald3 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

Drop --unsafe-perm from the publish job's npm ci. This flag was removed in npm 12, which we just started using.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release workflow to keep the publish job compatible with newer npm versions by removing the deprecated/removed --unsafe-perm flag from npm ci during publish.

Changes:

  • Remove --unsafe-perm from the publish job’s npm ci step in the production release workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/prod-release.yml
@lucasmcdonald3
lucasmcdonald3 requested a review from Copilot July 22, 2026 21:50
kessplas
kessplas previously approved these changes Jul 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

lucasmcdonald3 and others added 2 commits July 22, 2026 14:53
The publish job upgrades to npm@latest, which rejects the removed
unsafe-perm config. Dropping the --unsafe-perm CLI flag alone was
insufficient: the workflow-level NPM_CONFIG_UNSAFE_PERM env var sets the
same config key for every step, so remove it too.
@lucasmcdonald3
lucasmcdonald3 merged commit 4081d91 into master Jul 23, 2026
24 checks passed
@lucasmcdonald3
lucasmcdonald3 deleted the fix-master-publish-unsafe-perm branch July 23, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants