Skip to content

fix(ci): pass branch input into shared-ci for release workflow - #1674

Merged
lucasmcdonald3 merged 1 commit into
masterfrom
pass-branch-to-shared-ci
Jul 21, 2026
Merged

fix(ci): pass branch input into shared-ci for release workflow#1674
lucasmcdonald3 merged 1 commit into
masterfrom
pass-branch-to-shared-ci

Conversation

@lucasmcdonald3

@lucasmcdonald3 lucasmcdonald3 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

The release workflow wasn't running pre/post-release testing from the branch input, now it is

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

The release workflow runs from master but releases from a target branch
(e.g. v4.x) via the 'branch' input. The pre-release-ci and validate jobs
called shared-ci.yml without forwarding this input, so shared-ci defaulted
to checking out master and tested the wrong tree. Forward the branch input
so pre-release CI and post-publish validation run against the release branch.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the release workflow so that its reusable CI workflow (shared-ci.yml) checks out and tests the branch selected via the branch workflow_dispatch input, ensuring pre-release and post-release validation run against the intended source.

Changes:

  • Passes the branch workflow input into the pre-release-ci reusable workflow invocation.
  • Passes the branch workflow input into the validate reusable workflow invocation (post-publish tests).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lucasmcdonald3
lucasmcdonald3 merged commit 7237bf2 into master Jul 21, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants