fix(decrypt-node): single-consumer output stream for framed decrypt - #1672
Merged
Conversation
Route the decipher output through a single stream consumer (a terminal PassThrough exposed as the Duplexify readable) so every frame reaches the caller. Adds regression coverage for a multi-frame message (frameLength >= the stream highWaterMark) via the one-shot and streaming APIs. Backport of #1670 to the 4.x maintenance line. Co-authored-by: sharmabikram <10997020+sharmabikram@users.noreply.github.com>
lucasmcdonald3
changed the title
There was a problem hiding this comment.
Pull request overview
Fixes decrypt-node framed streaming decryption to ensure the decipher stream has a single consumer, preventing frame output from being lost, and adds a regression test vector to validate multi-frame plaintext integrity across different input chunkings.
Changes:
- Update
_decryptStreamto expose a single-consumerPassThroughas the readable side of the returned duplex stream. - Add a multi-frame ciphertext fixture (frameLength 16384; 3 frames; 40960-byte patterned plaintext).
- Add one-shot and streaming tests to assert decrypted plaintext matches expected bytes across chunk boundary scenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/decrypt-node/src/decrypt_stream.ts | Routes decipher output through a single PassThrough that is also the duplex readable side, avoiding multiple consumers of the decipher stream. |
| modules/decrypt-node/test/fixtures.ts | Adds a base64 fixture for a 3-frame, unsigned, non-committing message used to validate multi-frame decryption correctness. |
| modules/decrypt-node/test/decrypt.test.ts | Adds regression tests for one-shot and streaming decrypt to ensure full plaintext is returned across different ciphertext chunk sizes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sharmabikram
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(decrypt-node): single-consumer output stream for framed decrypt