Update setup.py#587
Open
amitaysh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI workflow uses pull_request_target and checks out untrusted pull request code (github.event.pull_request.head.sha) before executing a CodeBuild job with AWS credentials.
This creates a potential for arbitrary code execution in the CI environment with access to AWS credentials.
Although execution is currently gated by the integ-test environment approval, if this protection is misconfigured or bypassed, an attacker could execute malicious code from a pull request and gain access to AWS resources.
The workflow violates GitHub Actions security guidance by combining:
pull_request_target
checkout of untrusted PR code
privileged credentials (AWS access keys)
this PR comes to validate the flow and potentially becomes a bug bounty