Update ECS logs collector - #758
Open
tessaSlice wants to merge 3 commits into
Open
Conversation
tessaSlice
marked this pull request as ready for review
July 31, 2026 22:32
TheanLim
reviewed
Aug 1, 2026
| # This file tracks the latest ECS Logs Collector version available during AMI build. | ||
|
|
||
| d9f4f2989ef8ed0c83c680b5e9c1971bedb45ac7 No newline at end of file | ||
| c01bc32e87905363b1fc29c4c3072238eef79e20 |
TheanLim
reviewed
Aug 1, 2026
| modinfo nvidia > "$info_system"/gpu/gpu-installed-kmod.txt | ||
| fi | ||
|
|
||
| if [ -e /var/log/nv-hostengine.log ]; then |
Contributor
There was a problem hiding this comment.
I don't see L893 - L895 in the logs-collector repo
Why is it removed here?
Contributor
Author
There was a problem hiding this comment.
We don't need this since we're already redirecting the output of nv-hostengine log to the logs folder.
TheanLim
reviewed
Aug 1, 2026
|
|
||
| # datetime is the date and time when the script was executed used in pack() | ||
| datetime=$(date +%Y%m%d%H%M) | ||
| datetime=`date +%Y%m%d%H%M` |
Contributor
There was a problem hiding this comment.
this big diff mainly comes from the previous author running make fmt which formats all the shell scripts.
interestingly our PR Static Check check against different set of files, but this all goes back to our Makefile -- calling it out of scope to fix.
I'd suggest you to run make fmt too to minimize the diff
TheanLim
requested changes
Aug 1, 2026
added 2 commits
August 1, 2026 20:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ECS logs collector shell script copy on this repository has drifted from ECS logs collector repo: github.com/aws/amazon-ecs-logs-collector
Implementation details
Copy over
ecs-logs-collector.shfrom theamazon-ecs-logs-collectorrepository.Update
ECS_LOGS_COLLECTOR_VERSIONto reflect latest commit SHA in ECS logs repository.Testing
New tests cover the changes: yes
Description for the changelog
Enhancement - Update ECS Logs Collector
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.