Skip to content

test: standardize unit tests across all services (31 tests)#89

Merged
sliedig merged 4 commits into
developfrom
cross-runtime-test-consolidation
Jul 20, 2026
Merged

test: standardize unit tests across all services (31 tests)#89
sliedig merged 4 commits into
developfrom
cross-runtime-test-consolidation

Conversation

@sliedig

@sliedig sliedig commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue number: N/A

Summary

Changes

Standardize unit tests across all 4 .NET test projects to achieve exact parity with the Python, Java, and TypeScript runtimes (31 identical test cases across 7 Lambda functions).

  • Add coverlet.collector NuGet package to all 4 test .csproj files for coverage reporting
  • Create missing test classes: ContractStatusChangedEventHandlerTest.cs, WaitForContractApprovalFunctionTest.cs (approvals), and PublicationEvaluationEventHandlerTest.cs (web)
  • Add MissingNewImageShouldNotSendTaskSuccess test and event fixture for PropertiesApprovalSyncFunction
  • Remove extra .NET-specific serialization tests (snake_case_json tests from ContractEventHandler and RequestApproval) and redundant StatusIsDraftWithToken from PropertiesApprovalSync to align test cases across runtimes

User experience

Workshop participants running dotnet test will see the same 31 test cases as in the other 3 runtimes, with coverage reporting enabled via coverlet.

Checklist

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sliedig
test: standardize unit tests across all services (31 tests)
41a108e 
Add coverage tooling (coverlet), create missing test classes and
event fixtures, extend test cases for all 7 Lambda functions, and
remove extra tests to ensure parity with Python, Java, and TypeScript runtimes.
@sliedig
sliedig requested a review from a team as a code owner March 23, 2026 09:08
@github-actions

github-actions Bot commented Mar 23, 2026

Copy link
Copy Markdown

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions

github-actions Bot commented Mar 23, 2026

Copy link
Copy Markdown

No acknowledgement section found. Please make sure you used the template to open a PR and didn't remove the acknowledgment section. Check the template here: https://github.com/aws-samples/aws-serverless-developer-experience-workshop-dotnet/blob/develop/.github/PULL_REQUEST_TEMPLATE.md#acknowledgment

@github-actions github-actions Bot added do-not-merge PRs that are blocked for varying reasons need-issue PR is missing a related issue for tracking change need-license-agreement-acknowledge PRs that are missing acknowledgement section labels Mar 23, 2026
@sliedig
sliedig changed the base branch from main to develop March 24, 2026 04:40
sliedig added 3 commits March 26, 2026 00:48
@sliedig
test(contracts): standardize test event payloads with JSON fixtures
7425a83 
Replace SQS envelope event files with raw PascalCase payload fixtures.
Add LoadPayload helper, refactor tests to load from JSON files instead
of NBuilder inline construction. Remove NBuilder dependency.
@sliedig
test(approvals): Consolidate test event builders and remove legacy fi…
26aa03e 
…xtures

- Add NewContractStatusChangedEvent() builder method to TestHelpers for creating CloudWatchEvent test payloads
- Add NewWaitForContractApprovalInput() builder method to TestHelpers for Step Functions task-token inputs
- Replace inline event object construction in ContractStatusChangedEventHandlerTest with builder calls
- Replace inline payload construction in WaitForContractApprovalFunctionTest with builder call
- Remove legacy DynamoDbStreamEvents JSON fixture files from project configuration
- Remove unused System.Text.Json import from WaitForContractApprovalFunctionTest
- Remove unused Amazon.Lambda.CloudWatchEvents import from ContractStatusChangedEventHandlerTest (moved to TestHelpers)
- Improves test maintainability by centralizing test data builders and eliminating duplication
@sliedig
Merge branch 'develop' into cross-runtime-test-consolidation
e86f952 
# Conflicts:
#	Unicorn.Contracts/ContractsService.Test/ContractsService.Tests.csproj
@sliedig

sliedig commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Synced this branch with develop (merge commit e86f952) to pick up the recent dependency bumps and .NET lockfile additions.

Conflict resolved: ContractsService.Tests.csproj — both branches modified the test package set. Kept NSubstitute + coverlet.collector + Microsoft.NET.Test.Sdk 18.7.0 (this branch's coverage tooling), dropped develop's unused NBuilder addition (never referenced in test source), and regenerated packages.lock.json via dotnet restore --force-evaluate.

Verified after merge: dotnet build (0 errors) and dotnet test (28/28 passing across all 4 test projects).

@sliedig
sliedig requested review from adrianjhunter and removed request for a team July 3, 2026 06:45
@sliedig
sliedig merged commit 775c81b into develop Jul 20, 2026
1 check passed
@sliedig
sliedig deleted the cross-runtime-test-consolidation branch July 20, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianjhunter adrianjhunter Awaiting requested review from adrianjhunter

Assignees

No one assigned

Labels

do-not-merge PRs that are blocked for varying reasons need-issue PR is missing a related issue for tracking change need-license-agreement-acknowledge PRs that are missing acknowledgement section

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sliedig