Mark Pipeline.PipelineDefinition as is_document#355
Open
gustavodiaz7722 wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gustavodiaz7722 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/label release/patch |
ack-prow
Bot
added
the
release/patch
gustavodiaz7722
force-pushed
the
fix/pipeline-definition-is-document
branch
from
ae9840f to
c3445cf
Compare
Member
Author
|
Changes look good to me, waiting on review from team |
knottnt
reviewed
Jun 19, 2026
| // +kubebuilder:rbac:groups=sagemaker.services.k8s.aws,resources=domains,verbs=get;list;watch;create;update;patch;delete | ||
| // +kubebuilder:rbac:groups=sagemaker.services.k8s.aws,resources=domains/status,verbs=get;update;patch | ||
|
|
||
| var lateInitializeFieldNames = []string{"AppNetworkAccessType", "DefaultUserSettings.CodeEditorAppSettings", "DefaultUserSettings.CustomFileSystemConfigs", "DefaultUserSettings.CustomPosixUserConfig", "DefaultUserSettings.DefaultLandingURI", "DefaultUserSettings.JupyterLabAppSettings", "DefaultUserSettings.JupyterServerAppSettings", "DefaultUserSettings.KernelGatewayAppSettings", "DefaultUserSettings.RStudioServerProAppSettings", "DefaultUserSettings.SecurityGroups", "DefaultUserSettings.SharingSettings", "DefaultUserSettings.SpaceStorageSettings", "DefaultUserSettings.StudioWebPortal", "DefaultUserSettings.TensorBoardAppSettings"} |
Contributor
There was a problem hiding this comment.
@gustavodiaz7722 any idea why these are changing?
gustavodiaz7722
force-pushed
the
fix/pipeline-definition-is-document
branch
from
c3445cf to
6738fa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds is_document: true annotation to Pipeline.PipelineDefinition field in generator.yaml.
Problem
The Pipeline.PipelineDefinition field accepts an Amazon SageMaker Pipeline JSON definition document. Without the is_document annotation, the controller uses strict string comparison which causes false drift detection and infinite reconciliation loops when the API returns reformatted (but semantically equivalent) JSON.
Changes
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.