Repository navigation
fix: fall back to config sandbox paths in scanAgents - #1636
Merged
Merged
Conversation
The orchestrator invokes the raw scanAgents singleton without runtime options, so options.allowedPaths was undefined and every path was denied as "outside sandbox scope". Fall back to loadConfig().sandbox.paths when options.allowedPaths is absent, mirroring the other path tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The orchestrator invokes the
scanAgentstool as the raw singleton without runtime options, sooptions.allowedPathswasundefinedand every path was denied as "outside sandbox scope" — even paths inside the configured sandbox.scanAgentsImplnow falls back toloadConfig().sandbox.pathswhenoptions.allowedPathsis absent, mirroring the other path tools (file,discovery,readImage,audio).Type of Change
Testing
Ran
node \-\-test tests/unit/tools_scanAgents.test.js— all 7 tests pass. The existing tests all passoptions.allowedPathsexplicitly, so they exercise the primary path; the new fallback branch is a no-op whenallowedPathsis present, preserving existing behavior.Coverage
Checklist
npm run lintpasses