Repository navigation
Conversation
The /skills view rendered skills in discovery order because the catalog sort groups by location (.skills last) and returns 0 for every pair when all skills share a location. Sort the normalized items by label in the panel, matching the slash-command autocomplete ordering.
6 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
/skillspanel rendered skills in discovery order because the catalog sort groups by location (.skillslast) and returns0for every pair when all skills share a location. This change sorts the normalized items alphabetically in the panel, matching the slash-command autocomplete ordering inapp.js.Type of Change
Testing
Added a regression test in
tests/unit/tui/skillsPanel.test.jsthat feeds skills out of order and asserts the rendered output is alphabetical. The full TUI suite (449 tests) passes, including the new test.Coverage
Checklist
npm run lintpasses