Release these three through the marketplace - #10
Merged
Conversation
The v0.0.1 releases exist on GitHub and the marketplace has never heard of them: the publish step warned and carried on, exactly as it is written to when TERMCADE_TOKEN is absent. The key exists now, but those tags are cut and a release cannot be re-run over them — so this is a patch bump, which is the ordinary way to get a corrected release out either way. The pin moves to termcade v0.0.5 in both workflows. v0.0.4 predates publish keys entirely and still points at 127.0.0.1, so it could not have used the secret even with the secret set; the build and the publish stay on one version so a package is built by a termcade a player could also be running. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.yml(build and publish) andci.ymlWhy a patch bump rather than publishing what is already released
All three games have GitHub releases at
v0.0.1from Aug 1, and the marketplace has never heard of any of them:TERMCADE_TOKENwas not set, so the publish step took its documented warn-and-carry-on path. Those tags are cut, andrelease.ymlcannot be re-run over an existing tag — so a patch bump is the way through, which is what a corrected release would need anyway.Why the pin has to move
v0.0.4predates publish keys (aviorstudio/termcade#15) and still points at127.0.0.1:8080, so the publish step could not have used the secret even once it existed.v0.0.5readsTERMCADE_TOKENfrom the environment and defaults toapi.termca.de.Build and publish stay on the same version, so a package is still built by a termcade a player could also be running — the reason the pin exists.
After this merges
Dispatch
release.ymlonce per game. Each run builds the.tcade, tags<game>-v0.0.2, cuts the GitHub release, and then tells the registry — in that order, because publishing is a claim the registry verifies by fetching.Worth knowing: the starter packs vendored into the arcade are still 0.0.1, so a fresh termcade will seed 0.0.1 and correctly report v0.0.2 as available. Refreshing them is
go generate ./internal/starterfrom a termcade checkout, and is a separate change.🤖 Generated with Claude Code