Add CI, and gofmt the eight files it fails on - #1
Merged
Merged
Conversation
This repository had no CI. release.yml was the only workflow, so nothing checked a commit before it became a tag other repositories download a binary from -- fieldsofrevik's setup action pulls a gdlint release and puts it on PATH. Adding the check immediately found eight unformatted files. They are reformatted here rather than in a PR of their own, because the two changes are coupled: the CI cannot pass without the formatting, and the formatting has no reason to happen without the CI. Every hunk is gofmt's output -- no edits of my own. Release runs the same Test action. It packaged and published without running anything before. There are no _test.go files, so `go test ./...` reports "no test files" and passes. The step is here rather than omitted so the first test written is run the moment it lands, without anyone remembering to wire it up. Verified locally: gofmt clean, vet clean, build ok. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Third-party actions by SHA with the tag in a trailing comment, and a timeout so a hung step fails here rather than at the runner's own limit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository had no CI.
release.ymlwas the only workflow — so nothing checked a commit before it became a tag that other repositories download a binary from.fieldsofrevik's setup action pulls a gdlint release and puts it onPATH.Adding the check immediately found eight unformatted files
They're reformatted in the first commit here rather than a PR of their own, because the two changes are coupled — the CI can't pass without the formatting, and the formatting has no reason to happen without the CI. Every hunk is
gofmt's output, no edits of my own, so it reviews as one mechanical change.What's added
.github/actions/test— gofmt, vet,go test, build. Called by CI and Release; Release packaged and published without running anything before.ci.yml— one job,pull_request+push: [main](no CD here, so nothing else covers a merge).timeout-minuteson both workflows.On
go testThere are no
_test.gofiles, so it reports "no test files" and passes. The step is present rather than omitted so the first test written runs the moment it lands, without anyone remembering to wire it up.Verified locally: gofmt clean, vet clean, build ok.
Phase 3 of the standardization plan (F10).