Skip to content

Add CI, and gofmt the eight files it fails on - #1

Merged
nicodes merged 2 commits into
mainfrom
chore/add-ci
Aug 2, 2026
Merged

Add CI, and gofmt the eight files it fails on#1
nicodes merged 2 commits into
mainfrom
chore/add-ci

Conversation

@nicodes

@nicodes nicodes commented Aug 2, 2026

Copy link
Copy Markdown
Member

This repository had no CI. release.yml was the only workflow — so nothing checked a commit before it became a tag that other repositories download a binary from. fieldsofrevik's setup action pulls a gdlint release and puts it on PATH.

Adding the check immediately found eight unformatted files

src/core/entity_detector.go       src/operations/file_operations.go
src/core/indentation_checker.go   src/operations/remover.go
src/core/pass_analyzer.go         src/optimization/cache.go
src/models/entity.go              src/optimization/parallel.go

They're reformatted in the first commit here rather than a PR of their own, because the two changes are coupled — the CI can't pass without the formatting, and the formatting has no reason to happen without the CI. Every hunk is gofmt's output, no edits of my own, so it reviews as one mechanical change.

What's added

  • .github/actions/test — gofmt, vet, go test, build. Called by CI and Release; Release packaged and published without running anything before.
  • ci.yml — one job, pull_request + push: [main] (no CD here, so nothing else covers a merge).
  • SHA pins and timeout-minutes on both workflows.

On go test

There are no _test.go files, so it reports "no test files" and passes. The step is present rather than omitted so the first test written runs the moment it lands, without anyone remembering to wire it up.

Verified locally: gofmt clean, vet clean, build ok.

Phase 3 of the standardization plan (F10).

nicodes and others added 2 commits August 1, 2026 18:56
This repository had no CI. release.yml was the only workflow, so nothing
checked a commit before it became a tag other repositories download a
binary from -- fieldsofrevik's setup action pulls a gdlint release and
puts it on PATH.

Adding the check immediately found eight unformatted files. They are
reformatted here rather than in a PR of their own, because the two
changes are coupled: the CI cannot pass without the formatting, and the
formatting has no reason to happen without the CI. Every hunk is gofmt's
output -- no edits of my own.

Release runs the same Test action. It packaged and published without
running anything before.

There are no _test.go files, so `go test ./...` reports "no test files"
and passes. The step is here rather than omitted so the first test
written is run the moment it lands, without anyone remembering to wire
it up.

Verified locally: gofmt clean, vet clean, build ok.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Third-party actions by SHA with the tag in a trailing comment, and a
timeout so a hung step fails here rather than at the runner's own limit.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@nicodes
nicodes merged commit 5addef1 into main Aug 2, 2026
1 check passed
@nicodes
nicodes deleted the chore/add-ci branch August 2, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant