Standardize CI on the org shape - #1
Merged
Merged
Conversation
Build and Test become .github/actions/*, called as steps from a one-job ci.yml -- the same shape the rest of the organisation uses. The job is renamed build -> ci. The toolchain now comes from .mise.toml via mise-action, rather than oven-sh/setup-bun with the version written out in the workflow. bun was pinned in two places and only one of them is the one anybody edits. The no-JavaScript assertion now looks at the tree rather than grepping index.html for a <script src>. A bundle that is emitted but not yet referenced is still a runtime that arrived, and the emitting is the change worth catching. Verified against a local build first: this site emits zero .js files, so the stricter form passes today. This site's own assertions -- how many pages it emits, and what else has to be on them -- are preserved verbatim. That is the part worth keeping per-repo. Third-party actions pinned by SHA with the tag in a trailing comment, and timeout-minutes on the job. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings this repo onto the shape the rest of the organisation uses.
.github/actions/*, called from a one-jobci.yml. Job renamedbuild→ci..mise.tomlviajdx/mise-action, replacingoven-sh/setup-bunwith the version written out in the workflow — bun was pinned in two places and only one is the one anybody edits.timeout-minutes: 15.One behavioural change
The no-JavaScript assertion now checks the tree:
find dist -name '*.js'rather than grepping
index.htmlfor a<script src>. A bundle that's emitted but not yet referenced is still a runtime that arrived, and the emitting is the change worth catching.Verified against a local build first — this site emits 0
.jsfiles, so the stricter form passes today. I built all four-webrepos and checked before switching any of them.Preserved verbatim
This site's own assertions — how many pages it emits, and what else has to be on them — are unchanged. That's the part worth keeping per-repo, and it's what differs between the four.
Phase 5 of the standardization plan.