Add production durability check#5
Open
avikalpg wants to merge 1 commit into
Open
Conversation
Replace the implementation-coupled isolate-loss unit test with a public HTTP canary that validates user-visible counter durability after the flush window. Keep CI unit tests focused on local API behavior.
avikalpg
force-pushed
the
nia/add-durability-regression-test
branch
from
92780ac to
556ecbe
Compare
avikalpg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run test:production-durability, which hits the public HTTP API with a unique key, waits past the flush window, then verifiesreadOnly=truestill sees the incrementWhy
The durability failure depends on real Cloudflare runtime behavior, not just application code. CI unit tests should stay user-behavior focused and deterministic; this check is intentionally run against a deployed endpoint.
Test
npm testpassesCOUNTER_BASE_URL= npm run test:production-durabilityprints usage and exits 2 as expected