fix(ticket-088): ignore overlapping source projection conflicts - #103
Conversation
There was a problem hiding this comment.
Deterministic Validator approval for exact head a37f4020c0f0719cbb1a9336c9d03b895071972d.
Ticket: ticket-088
Correlation ID: todo2code-pr-103-ticket-088
Model: zai/glm-5.3
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). Chunk adds governance scaffold for ticket-088 and a narrow source-overlap guard in linker.ts that suppresses 'contradicts' between opposite-polarity records from overlapping ranges of the same normalized source path, preserving cross-source contradictions. Diff is scoped to allowed paths; all reported checks pass (verify, code-review, Java adapter, focused linker tests 16/16). | Chunk adds isOverlappingSameSourceProjection, which suppresses contradictions between opposite-polarity records whose normalized source paths match and line ranges overlap, treating them as alternate projections of one source location. Tests cover both the suppression case (overlapping ranges, different sourceKind, path variants './' vs bare) and preservation of a genuine contradiction from independent files. The call site of the new helper is presumably in the other chunk of this diff.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.
Decision record (recomputable)
DECISION D-088-8740
TICKET ticket-088
HEAD_SHA a37f4020c0f0719cbb1a9336c9d03b895071972d
CORRELATION_ID todo2code-pr-103-ticket-088
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["Live OpenRouter contract (opt-in)=SKIPPING","governance=SKIPPING","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Summary
Validation
node --test dist/test/linker-pairing.test.js(16/16)npm run verifymake docker-smoke