Skip to content

refactor(nlp2cmd): split pipeline_runner_browser_multi into mixins - #4

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
refactor/pipeline-browser-multi-split
Sep 1, 2026
Merged

refactor(nlp2cmd): split pipeline_runner_browser_multi into mixins#4
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
refactor/pipeline-browser-multi-split

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Summary

  • Split the 1466-line pipeline_runner_browser_multi.py god module into focused mixins (nav, forms, extract, persist) with shared MultiActionState.
  • Keep BrowserMultiActionMixin as a thin orchestrator that dispatches legacy multi-action handlers.

Test plan

  • python -m compileall src/nlp2cmd/pipeline_runner_browser_multi*.py
  • pytest tests/unit/test_pipeline_runner_step_errors.py tests/unit/test_browser_automation.py tests/unit/test_intract_pipeline_gate.py (63 passed)

Made with Cursor

Move legacy multi-action handlers into nav/form/extract/persist mixins
with shared MultiActionState; keep BrowserMultiActionMixin as orchestrator.

Co-authored-by: Cursor <cursoragent@cursor.com>

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic Validator approval for exact head c3d09f701971e5f7d8f127b61dc63c852b9e8602.

Ticket: ticket-064
Correlation ID: nlp2cmd-pr-4-ticket-064
Model: zai/glm-5.3
Advisory LLM review: LLM_UNAVAILABLE
Reason: advisory_review_budget_exceeded: full review requires 14 chunks; limit is 8
This approval rests on the deterministic checks alone; no advisory opinion was recorded for this head.
Merge will be attempted after this approval when explicitly authorized.

Decision record (recomputable)

DECISION D-064-5450
TICKET ticket-064
HEAD_SHA c3d09f701971e5f7d8f127b61dc63c852b9e8602
CORRELATION_ID nlp2cmd-pr-4-ticket-064
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test (3.11)=PASS","test (3.12)=PASS"]
INPUT required_checks = ["test (3.11)","test (3.12)"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT superseded_checks = []
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit d810815 into main Sep 1, 2026
2 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the refactor/pipeline-browser-multi-split branch September 1, 2026 14:34
@tom-sapletta-com
tom-sapletta-com restored the refactor/pipeline-browser-multi-split branch September 1, 2026 15:05
@tom-sapletta-com
tom-sapletta-com deleted the refactor/pipeline-browser-multi-split branch September 1, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant