refactor: split site_explorer into focused modules - #2
Merged
Conversation
Extract HF browser automation and shared check types from the 1388-line doctor command module (STARTER-008); keep doctor.py as CLI facade.
Extract types/constants and page-analysis helpers from the 1700-line site_explorer module. Fix find_content fast-path using content_type instead of undefined intent variable.
subactor-subllm requires Python >=3.11; align requires-python and CI matrix so dependency install succeeds on all jobs.
is_configured delegates to available_routes; stub it in the unit test so CI does not depend on live route credentials.
![ifuri-validator-agent[bot]](https://avatars.githubusercontent.com/in/4344831?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Deterministic Validator approval for exact head 1ffd4ba3d8d5579e871571e2b4e1c4c6fa36f97e.
Ticket: ticket-000
Correlation ID: nlp2cmd-pr-2-ticket-000
Model: zai/glm-5.3
Advisory LLM review: LLM_UNAVAILABLE
Reason: advisory_review_budget_exceeded: full review requires 12 chunks; limit is 8
This approval rests on the deterministic checks alone; no advisory opinion was recorded for this head.
Merge will be attempted after this approval when explicitly authorized.
Decision record (recomputable)
DECISION D-000-0519
TICKET ticket-000
HEAD_SHA 1ffd4ba3d8d5579e871571e2b4e1c4c6fa36f97e
CORRELATION_ID nlp2cmd-pr-2-ticket-000
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test (3.12)=PASS","test (3.11)=PASS"]
INPUT required_checks = ["test (3.11)","test (3.12)"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT superseded_checks = []
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
site_explorer_types.py(dataclasses, constants, platform URL helpers)site_explorer_page.py(page analysis mixin)site_explorer.pyfacade (~1050 lines)find_contentfast-path (content_typevs undefinedintent)Test plan
from nlp2cmd.web_schema.site_explorer import SiteExplorerworksMade with Cursor