Skip to content

Remove obsolete AppVeyor VersionPrefix from csproj#58

Merged
tillig merged 1 commit into
developfrom
feature/remove-appveyor-version-prefix
May 22, 2026
Merged

Remove obsolete AppVeyor VersionPrefix from csproj#58
tillig merged 1 commit into
developfrom
feature/remove-appveyor-version-prefix

Conversation

@tillig
Copy link
Copy Markdown
Member

@tillig tillig commented May 22, 2026

Summary

  • Removes the <VersionPrefix> property and associated AppVeyor comment from the source .csproj
  • Version is set by default.proj via /p:Version during GitHub Actions CI, making the csproj entry unnecessary
  • Eliminates risk of accidentally building with a dummy 0.0.1 version outside the normal pipeline

Test plan

  • CI build passes (version still correctly set by default.proj)
  • Verify produced package has correct version suffix based on branch

The VersionPrefix property was a leftover from AppVeyor builds.
Version is now set by default.proj via /p:Version during GitHub
Actions CI, making this entry unnecessary and potentially confusing.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.93%. Comparing base (2e3e72c) to head (e6b25c7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #58   +/-   ##
========================================
  Coverage    91.93%   91.93%           
========================================
  Files            2        2           
  Lines          124      124           
  Branches        22       22           
========================================
  Hits           114      114           
  Misses           6        6           
  Partials         4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tillig tillig merged commit b7ca1f3 into develop May 22, 2026
10 checks passed
@tillig tillig deleted the feature/remove-appveyor-version-prefix branch May 22, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant