chore: bump deps - #203
Merged
Merged
Conversation
miparnisari
force-pushed
the
update-spicedb
branch
from
August 20, 2026 23:36
91d75dd to
5781e5c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
miparnisari
marked this pull request as ready for review
August 20, 2026 23:58
miparnisari
force-pushed
the
update-spicedb
branch
from
August 21, 2026 16:23
5781e5c to
128a547
Compare
tstirrat15
approved these changes
Aug 21, 2026
| buf.build/gen/go/prometheus/prometheus/protocolbuffers/go v1.36.10-20251118093737-4105057cc7d4.1 // indirect | ||
| buf.build/go/protovalidate v1.1.3 // indirect | ||
| cel.dev/expr v0.25.1 // indirect | ||
| buf.build/go/protovalidate v1.2.0 // indirect |
Contributor
There was a problem hiding this comment.
1.3? Or are we not worried about that?
| req.URL.Scheme = "https" | ||
| req.Out.URL.Host = strings.TrimSuffix(host, "/") | ||
| req.Out.URL.Scheme = "https" | ||
| req.SetXForwarded() |
Contributor
There was a problem hiding this comment.
What does this change do?
Contributor
Author
There was a problem hiding this comment.
see https://pkg.go.dev/net/http/httputil#ReverseProxy.Director
Director used to preserve X-Forwarded-For. Rewrite does not so we manually add it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.