Repository navigation
fix: keep an unreadable repository out of the team comparison and merge object overrides - #109
Merged
Merged
Conversation
…ge object overrides A cross-check of the merged settings check against the two baselines and the shared guidance found: - When the read of one repository failed, its team grants were reported as gone (exit 1) instead of the run ending with one could-not-verify line (exit 2). - An override of an object key such as `repository` replaced the whole key, so a one-field override silently stopped the comparison of every other merge setting. An object override now changes only the entries it names. - README, AGENTS.md and the baseline note said to update the baseline "until the check is clean". That invited recording differences the task did not cause, and is unreachable while the webhooks line prints. They now match the other organization's wording: record only the authorized change, explain each remaining line, and record anything else only with the owner's explicit approval. - AGENTS.md scoped its commands to Atrinik and says where another organization's baseline pull request goes. - A reminder named the owner's workstation; it no longer does. Co-Authored-By: Claude <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Review of 7058641 noted that the README did not say how deep the merge goes, so a partial `branch_rules` override could be written in the belief that the rule's other parameters stay compared. Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Self-review of What was reviewed
Findings
No other finding. Declined: nothing. Where the changes came from A cross-check of #108 with the other organization's baseline and the shared guidance, run after #108 merged, found the two code defects and the "until the check is clean" wording. An independent skeptic reproduced each one offline with this repository's fixtures before it was fixed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two defects in the read-only settings check that #108 added, and brings its texts in line with the shared agent guidance. A cross-check of the three settings pull requests, read together for the first time after #108 merged, found them.
repository, now changes only the entries it names.Intent brief
classic's security configuration), so nothing changes for the current baseline.gh api -X GET, exit codes 0/1/2/3, at most 550 lines (545 now), standard library only.Implementation / behavior
check_settings.py:check_repositoriesadds a repository to the unread set when its own read fails;profile_formerges an object-valued override into the profile's object.tests/test_check_settings.py: one test for each, both failing on the old code.README.md: step 4 of "How a change is made", the sentence about fix commands, and therepositoriesrow of the baseline table, which now says the merge is one level deep.AGENTS.md: the change bullet, the scope of the run command, and where another organization's baseline pull request goes.baselines/atrinik.json: the note about quoting output, and one reminder that named the owner's workstation.Validation
python3 -m unittest discover -s tests: 37 tests pass, offline.python3 .github/scripts/check_repository.py: no problems.python3 check_settings.py --validate baselines/atrinik.json: valid.git diff --check: clean.7058641(the later commit changes only the README), exit 2:That line is expected: the everyday login cannot read organization webhooks.
Limitations / follow-up
branch_rulesoverride must list all the parameters of a rule it names. Nothing uses either today.atrinik/agent-integrationsskills still do not name this check.🤖 Generated with Claude Code