Repository navigation
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
|
Reviewed exact head The full review inspected all six changed files, affected credential schema and name-only verifier paths, current metaserver source, security/failure behavior, tests and documentation. Retained delivery read credentials, protected branches, recovery key and API failure checks are preserved. No workflow or Project mutation code changed. Finding: P2 at tests/validate-manual-credentials.sh:259, stale numeric index made a negative DEV test a no-op. Fixed in Validation so far: Keep this PR draft pending owner review of the downstream Project plan (43 planned changes at preparation). No apply, Project synchronization, workflow dispatch, secret provisioning, live policy changes or merge authorized/performed. |
|
Reviewed exact head Fresh-context independent Astra review covered the full initial six-file diff, affected schema/verifier, current metaserver workflows, security/failure behavior and docs/tests. One P2 stale numeric test index was fixed in A further fresh-context independent Astra review covered the final Pages delta Validation: all local Keep draft pending owner review of the downstream Project plan (43 planned changes at preparation) and production environment drift. No apply, synchronization, workflow dispatch, secret provisioning, live policy/Pages changes or merge performed. |
|
Reviewed exact head Fresh-context independent Astra review covered the full initial six-file diff, affected schema/verifier, current metaserver workflows, security/failure behavior and docs/tests. One P2 stale numeric test index was fixed in A further fresh-context independent Astra review covered the final Pages delta Validation: all local Keep draft pending owner review of the downstream Project plan (43 planned changes at preparation) and production environment drift. No apply, synchronization, workflow dispatch, secret provisioning, live policy/Pages changes or merge performed. Mechanical documentation delta |
…er-credential-inventory
|
Reviewed exact head Fresh-context independent GPT-6.1 Sol high review examined the prior-head delta, complete six-file net cleanup, affected credential/environment/Pages validation, and semantic interaction with PR105 ruleset normalization, preservation, concurrency fences, audit integration, tests and documentation. No P0–P3 findings. There were no conflict resolutions or new authored code beyond the clean merge. Validation: all 29 Keep draft pending both owner decisions: adopt or remove the existing production |
The live atrinik/metaserver-worker production environment requires the
organization owner (User 3865595) as reviewer, while the inventory
recorded an empty set, so bin/verify-manual-settings reported reviewer
drift. By owner decision of 2026-11-14 the live reviewer stays and is
recorded here.
- config: record [{type: User, id: 3865595}] for that environment.
- bin/validate: replace the blanket empty-reviewer rule. A record for
atrinik/metaserver-worker production must carry repository ID
1324297032 and exactly the owner as reviewer; every other recorded
environment must have none. Removing the record altogether is still
caught only by the exact-inventory test, as for every environment.
- bin/verify-manual-settings: project the recorded reviewers to
{type, id} before the string comparison so config key order cannot
cause false drift.
- tests: reject missing, different, Team, extra, duplicate and
malformed production reviewers, the owner on any other environment,
and production under another repository name or ID; cover live
production reviewer drift in both directions.
- README: the owner is the single required reviewer; her dispatch and
her approval of the pending deployment form the approval boundary.
prevent_self_review and administrator bypass remain unrecorded and
unverified for these environments.
Co-Authored-By: Claude <noreply@anthropic.com>
|
Closing without merging, by owner decision of 2026-11-14. The settings automation that this pull request was repairing is being retired rather than repaired. Its credential, What is left as it was:
A simpler approach to keeping the organization's settings will be proposed separately. |
Summary
Reconcile the manual-settings inventory with reviewed producer workflows and live settings so that read-only verification passes its credential, Pages and environment checks again. The pull request does three things:
productionenvironment, by owner decision of 2026-11-14.It does not by itself restore Project synchronization. See Limitations / follow-up.
Implementation / behavior
ATRINIK_PRODUCTION_BUILDS_READ_TOKENandATRINIK_PRODUCTION_WRITER_FENCE_POLICYinventory entries. Preserve the current delivery-resource read token, deployment credentials, protected-branch policies, recovery key, and verification guards.actions/deploy-pages@368f82528645a54fb793d4d04e342629a3f51346(v5.0.1), already merged through Classic PR #547. The old marker incorrectly classified the existing Actions site as awaiting activation.[{"type": "User", "id": 3865595}]asrequired_reviewerson theatrinik/metaserver-workerproductionenvironment. The live environment already has this reviewer; the inventory said none.bin/validate: replace the blanket empty-reviewer rule. A record foratrinik/metaserver-workerproductionmust carry repository ID1324297032and exactly the owner as reviewer. Every other recorded environment must still have no reviewers.bin/verify-manual-settings: project the recorded reviewers to{type, id}before the string comparison. Without this, the recorded key order caused false drift against the live projection.README.md: the owner is the single required reviewer on metaserver production. Her dispatch of the exact reviewed inputs and her approval of the pending deployment together form the approval boundary.Validation
At head
6329066, withATRINIK_VALIDATION_TODAY=2026-11-08:bin/validatepasses, and all 29tests/*.shpass.bash -nandgit diff --checkare clean.bin/verify-manual-settingsagainst live GitHub exits 0, includingKEEP atrinik/metaserver-worker environment production metadata. At the previous head9f9c520the same run stops withrequired reviewer drift for atrinik/metaserver-worker production.scripts/production-promotion.mjsinatrinik/metaserver-workeraccepts a well-formedrequired_reviewersrule and requires one approved review for the environment, so recording the reviewer matches it.On the real date, 2026-11-14,
bin/validateexits 1 onmainand on this branch alike, because three lifecycle records have passed their deadlines (next section). Hosted Policy validation therefore fails on this head for a reason this pull request did not introduce.Earlier validation of the first three changes, at
9f9c520on 2026-11-01, is recorded in the self-review receipts below.Limitations / follow-up
Draft until the expired lifecycle records are renewed. Each needs a real owner action first; the dates must not be moved forward without it.
ATRINIK_SETTINGS_TOKEN(atrinik/github-settings)rotate_by2026-11-08Bad credentials (HTTP 401), so the old token is dead; later runs stop earlier, at validation.DEPENDENCY_UPDATE_APP_PRIVATE_KEY(atrinik/classic)rotate_by2026-11-09review_by2026-11-13admin:org,projectandrepo. The verifier also reads the privatelinux-buildpackage record, which may needread:packages. This is unconfirmed, because no run with the settings token has reached that step.Synchronize projectandProject synchronization healthshould recover.Governance drift auditwill keep failing on governance drift that this pull request does not address; the eight publisher operations need separate authorization.prevent_self_review(live: false) and administrator bypass are not recorded or verified for this environment.Intent brief
Goal: remove stale manual-settings inventory blockers using current reviewed source and live name and configuration evidence, so that read-only verification can pass and Project synchronization can resume once the settings credential is renewed.
Decisions: keep the live production reviewer and record it, as the smallest exception to the empty-reviewer rule; pin it by repository name, repository ID and environment; leave every other environment's rule unchanged.
Constraints: preserve all security and verification controls; record lifecycle dates only after the owner's real rotation or review.
Excluded: broader ruleset and default drift, runtime repair, live operations, and Project reconciliation. These need separate coordination or owner approval.
🤖 Generated with Claude Code