Update actions - #171
Merged
Merged
Conversation
Contributor
Reviewer's GuideThis PR modernizes the repository’s CI and formatting infrastructure by upgrading GitHub Actions workflows, replacing legacy pre-commit hooks and lint settings with a new Ruff-based stack, and applying the resulting automatic formatting fixes across the codebase. Entity relationship diagram for updated pre-commit configurationerDiagram
PRE_COMMIT_CONFIG ||--|{ REPO : contains
REPO {
string url
string rev
string[] hooks
}
HOOK {
string id
string[] args
string[] exclude_types
}
PRE_COMMIT_CONFIG {
REPO[] repos
}
REPO ||--|{ HOOK : has
PRE_COMMIT_CONFIG ||--|{ RUFF_CONFIG : uses
RUFF_CONFIG {
int line_length
string[] ignore
string[] select
string[] known_first_party
string[] known_third_party
string[] per_file_ignores
}
Class diagram for updated ConditionalFlowMatcher and subclassesclassDiagram
class ConditionalFlowMatcher {
+float sigma
+__init__(sigma: Union[float, int] = 0.0)
+compute_lambda(t)
}
class ExactOptimalTransportConditionalFlowMatcher {
+OTPlanSampler ot_sampler
+__init__(sigma: Union[float, int] = 0.0)
+sample_location_and_conditional_flow()
}
class TargetConditionalFlowMatcher {
+compute_mu_t()
+compute_sigma_t()
+compute_conditional_flow()
}
class SchrodingerBridgeConditionalFlowMatcher {
+__init__(sigma: Union[float, int] = 1.0, ot_method="exact")
+compute_sigma_t()
+compute_conditional_flow()
+sample_location_and_conditional_flow()
}
class VariancePreservingConditionalFlowMatcher {
+compute_mu_t()
+compute_conditional_flow()
}
ConditionalFlowMatcher <|-- ExactOptimalTransportConditionalFlowMatcher
ConditionalFlowMatcher <|-- TargetConditionalFlowMatcher
ConditionalFlowMatcher <|-- SchrodingerBridgeConditionalFlowMatcher
ConditionalFlowMatcher <|-- VariancePreservingConditionalFlowMatcher
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Double-check that switching the GitHub action to Python 3.13 is supported by all your dependencies and runners, as 3.13 may not yet be stable in some environments.
- Since bandit was removed in favor of gitleaks, consider re-adding a dedicated Python security linter or enabling ruff’s security plugins to retain deeper vulnerability scanning.
- Verify that renaming the workflow to code-quality.yaml and adding pull_request triggers on main and release/* still aligns with your CI/CD expectations and fires correctly.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Double-check that switching the GitHub action to Python 3.13 is supported by all your dependencies and runners, as 3.13 may not yet be stable in some environments.
- Since bandit was removed in favor of gitleaks, consider re-adding a dedicated Python security linter or enabling ruff’s security plugins to retain deeper vulnerability scanning.
- Verify that renaming the workflow to code-quality.yaml and adding pull_request triggers on main and release/* still aligns with your CI/CD expectations and fires correctly.
## Individual Comments
### Comment 1
<location> `tests/test_models.py:8` </location>
<code_context>
def test_initialize_models():
- model = UNetModel(
+ UNetModel(
dim=(1, 28, 28),
num_channels=32,
</code_context>
<issue_to_address>
Missing assertions in model initialization test.
Add assertions to verify correct model instantiation and expected key properties, such as output shapes and parameter counts.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| from torchcfm.models import MLP | ||
| from torchcfm.models.unet import UNetModel | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
suggestion (testing): Missing assertions in model initialization test.
Add assertions to verify correct model instantiation and expected key properties, such as output shapes and parameter counts.
| @@ -119,7 +120,7 @@ def plot_paths(self): | |||
| plt.show() | |||
|
|
|||
| def factory(name, args): | |||
Contributor
There was a problem hiding this comment.
issue (code-quality): The first argument to instance methods should be self (instance-method-first-arg-name)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github actions for this repo have not been updated in a while. This PR seeks to update to a more modern workflow.
ruff,gitleaks,prettierSummary by Sourcery
Modernize the repository’s code quality and CI tooling by upgrading pre-commit hooks and GitHub Actions workflows, adopting a new formatting stack (ruff, gitleaks, prettier), and applying automated fixes and cleanup across the codebase.
Enhancements:
CI:
Documentation:
Tests:
Chores: