Add typed call responses and validated acknowledgements - #2
Merged
Merged
Conversation
Add request validation and model serialization to call(), validate typed acknowledgements, and serialize validated handler responses across sync and async APIs. Preserve Python 3.8 support and verify runtime and static contracts. Co-authored-by: Fabian Zills <fzills@icp.uni-stuttgart.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call()across sync and async Server/Client APIs.response_modelvalidation for acknowledgements and validate handler return annotations before serializing model responses.Verification
Related to #1. Thanks @PythonFZ for the typed response and handler return validation proposal.