fix(PromptConverter): parse JSON header properties - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolandarrayonly as standalone top-level markerstype="tool_calls"/type="content_array"headersProblem
msgs2raw()serializes arbitrary response metadata withjson.dumps(), whileraw2msgs()previously consumed only quoted string values. JSON arrays, objects,null, booleans, and numbers were left partially parsed, allowing nested words such astoolorarrayto be mistaken for message-type markers.This could turn a normal JSON content string into
tool_callsor structured content and drop response metadata.Validation
52 passedruff check src tests examplesruff format src tests examples --check --diff