Give freeform an upper witness without restoring a length cap - #843
Conversation
atomchung
left a comment
There was a problem hiding this comment.
BLOCK — the upper witness repeats the same provenance on two floors.
The three researched claims already satisfy C2 by naming source + date inline (WDGT 8-K, investor presentation, Northstar Ratings). The final caliber line then lists the same three sources and dates again. That teaches the generation path to pay twice for the same provenance, directly against D6 and D7's “nothing appears on two floors” rule—the exact semantic class the deterministic E-5…E-8 checks intentionally cannot catch.
Smallest repair: keep the inline source/date beside each public fact, and reduce the end block to the book/pricing frame plus material gaps, e.g. (帳本 8/14、價格 8/14 收盤;未評反壟斷通過機率與交易後估值). Apply the same edit to the corpus copy and the fenced generation-path copy, then rerun both CI groups.
Everything else in the two-file slice is appropriately bounded: compact lower witnesses remain, the richer scene is explicitly an upper—not default—witness, the freeform/plain-conversation scope is consistent with the existing route contract, and no engine/state/privacy/execution boundary changes. GitHub cannot accept an approval from the repository owner, so this is recorded as a blocking COMMENT review.
Blocker repaired and re-reviewedCommit
Final semantic review found no remaining blocker. The PR still changes exactly two synchronized surfaces: the freeform generation-path exemplar and its canonical corpus copy. It changes no engine, schema, persistence, execution state, privacy boundary, or other route. Verification on the exact final tree:
Mechanical and semantic acceptance for this PR are complete. Behavioral acceptance is deliberately still open: #836 requires the frozen simple-lookup versus research-heavy owner-live comparison before this pattern expands to another surface. Merge remains an owner decision. |
User outcome
A simple lookup stays short. A research-heavy decision can carry several sourced increments when each one changes the call, instead of being implicitly compressed toward a corpus in which every positive exemplar was under 400 characters.
Current behavior / evidence
Change
freeform_research_depthpositive with eight distinct increments, explicit source/as-of provenance, an engine-owned portfolio consequence, a contextual research judgment, and observable falsifiers;references/freeform-answers.md;Scope / non-goals
This is deliberately one surface. It changes no engine, schema, persisted state, transaction lifecycle, execution truth, privacy boundary, or other conversational route.
consider,no_book, andweekly_readremain unchanged until owner-live evidence shows they need the same treatment.Acceptance
freeformstays inside the corpus's 3–5 positive-exemplar range;Privacy / rollout / recovery
All issuers, ratings sources, prices, dates, holdings, and deal facts are synthetic. The change is reversible by restoring the previous freeform fence and removing one fixture scene; no migration or recovery path is involved.
Refs #836. This PR does not close it: the issue remains open until owner-live evidence decides whether any other surface needs an upper witness.