fix: read embedding models from public status (#6703) - #6704
Merged
Conversation
Owner
Author
|
Optional local Claude review was inconclusive because the reviewer produced no verdict. The focused client test could not start in this fresh worktree because dependencies are not installed ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the public local LLM status
modelsarrays when populating embedding choices, and add rendered regression coverage for both backends, refresh behavior, empty results, known suggestions, and manual model entry.Tests:
npm test -- --run src/components/settings/EmbeddingsTab.test.jsx(passed);npx biome lint --error-on-warnings src/components/settings/EmbeddingsTab.jsx src/components/settings/EmbeddingsTab.test.jsx(passed). The regression test fails against the formerinstalledModelsreads (exit 1) and passes with themodelsfix.Closes #6703