Skip to content

fix: clarify database selection during setup - #6696

Merged
atomantic merged 1 commit into
mainfrom
cos/app-improve-portos-default-documentation-mttnjjg5/agent-89783d06
Sep 9, 2026
Merged

fix: clarify database selection during setup#6696
atomantic merged 1 commit into
mainfrom
cos/app-improve-portos-default-documentation-mttnjjg5/agent-89783d06

Conversation

@atomantic

Copy link
Copy Markdown
Owner

Summary

Correct the database setup guide's claim that a healthy native database is always detected first. With Docker available, an unset PGMODE selects Docker instead, potentially pointing a reader at a separate empty database.

  • Evidence: docs/STORAGE.md:153 and its former readiness-first sequence at line 174 contradict scripts/setup-db.js:51, scripts/setup-db.js:285, and scripts/setup-db.js:357.
  • Document explicit native selection, the conditional native fallback, and the distinction between selecting a database and migrating records.

Test plan

  • cd server && npm test -- ../scripts/setup-db.test.js — 8 tests passed.
  • Checked the documented branches against setup-db.js and the Docker Compose configuration; no database provisioning was executed.
  • git diff --check passed.

@atomantic
atomantic merged commit 59ae2da into main Sep 9, 2026
7 checks passed
@atomantic
atomantic deleted the cos/app-improve-portos-default-documentation-mttnjjg5/agent-89783d06 branch September 9, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant