🐛 Fixed not ignoring nested git repositories

[segiddins]

For example, suppose you have a repo, Rainforest,
whose .gitignore is simply *.
Inside Rainforest is another git repo, Repo.
If you open Repo as your project directory,
it will now be auto-completed, as the root
is no longer considered ignored.

Fixes a situation described in #87.

[winstliu]

It looks like you broke a spec with this change - could you please fix it and add a spec that tests this change? Thanks.

[segiddins]

I don't really understand what the spec I broke is testing. I'd be happy to add a new spec for this change, but I've really only poked around and am not too familiar with how to test this change.

[segiddins]

I'd appreciate some help in understanding what the failing test is actually trying to test so I can fix it and get this PR merged.

[lee-dohm]

Test code:

    describe "when core.excludeVcsIgnoredPaths is set to true", ->
      beforeEach ->
        atom.config.set("core.excludeVcsIgnoredPaths", true)

      describe "when the .gitignore matches parts of the path to the root folder", ->
        beforeEach ->
          ignoreFile = path.join(projectPath, '.gitignore')
          fs.writeFileSync(ignoreFile, path.basename(projectPath))

        it "only applies the .gitignore patterns to relative paths within the root folder", ->
          dispatchCommand('toggle-file-finder')
          projectView.setMaxItems(Infinity)

          waitForPathsToDisplay(projectView)

          runs ->
            expect(projectView.list.find("li:contains(file.txt)")).toExist()

What this is doing is:

1. When the "Exclude VCS Ignored Paths" setting is true
2. And some part of the project path itself is in the .gitignore file (ex: your project is at /home/username/project/foo and project is in the .gitignore file)
3. The files inside your project (that aren't in a /home/username/project/foo/**/project/ directory) still show up

[segiddins]

This is now passing!

[segiddins]

(See also atom/git-utils#45)

[segiddins]

What can I do to help get this 🚢?

[kevinsawicki]

What can I do to help get this 🚢?

Adding an additional spec that tests what this fixes would help to get this shipped.

[segiddins]

I just tried to come up with a spec for this, but I'm struggling, sorry.