Repository navigation
fix(sidebar): keep groups in Working while any member runs - #81
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A finished, unsettled child pulled its whole group into Active even while the parent was still running, so a working group showed outside the Working shelf. Finished children now count as review only once nothing else in their group is working. Approvals, questions, guest messages and plans still surface the group immediately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A thread group whose parent was still running showed in the Active list instead of the Working shelf whenever one of its children had finished but wasn't settled yet. The group's own status pill said "Working" while its section said otherwise.
resolveThreadGroupSectionscounted any finished, unsettled member as "needs review", and review outranks working. It now separates two kinds of attention:The function lives in
client-runtime, so web and mobile both pick this up. The nested-group test now asserts that a finished child under a working group stays in Working and moves to Active once the worker stops; it fails on the old logic. The user docs' grouping paragraph is updated to match.A second commit removes an unused
exportleft by #80 (resolvePendingUserInputCompanionAnswer), which was failing knip in the pre-commit hook and CI.Not checked in a running client; the change is pure section logic covered by the test.
Done with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code