Gridded PSF performance improvement#2289
Open
keflavich wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve performance of GriddedPSF evaluation.
At a low level, some of these steps get ~10x speedups. However, I think they contribute negligibly to overall speed for most cases, so I'm not sure we should merge this - the slight cost in code complexity may be not worth it.
Evaluating this PR requires tests against a new benchmark:
astropy/photutils-benchmarks#5
Low-level improvement:
If this 15% improvement really holds up on realistic cases, it's... maybe worthwhile?
Claude Haiku 4.5 contributed a bunch to this.