[codex] Fix EllipseSample geometry sma cache reset#2280
Merged
Conversation
larrybradley
approved these changes
May 29, 2026
Member
larrybradley
left a comment
There was a problem hiding this comment.
Many thanks, @hgao-astro! I added a changelog entry for this bugfix and will merge when CI passes.
d21ea5a to
9bede7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2105 by resetting EllipseGeometry attributes that are derived from sma when EllipseSample is constructed from an existing geometry and a new semimajor axis.
The root cause was that EllipseSample deep-copied the input geometry and overwrote geometry.sma, but left cached SMA-dependent values such as _area_factor, sector_angular_width, initial_polar_angle, and initial_polar_radius from the original geometry.
Changes
Validation