Skip to content

Remove scikit-image runtime dependency#923

Merged
mwcraig merged 2 commits into
astropy:mainfrom
karlhillx:remove-scikit-image-dep
Jun 3, 2026
Merged

Remove scikit-image runtime dependency#923
mwcraig merged 2 commits into
astropy:mainfrom
karlhillx:remove-scikit-image-dep

Conversation

@karlhillx
Copy link
Copy Markdown
Contributor

ccdproc's block_reduce/block_average/block_replicate wrappers all delegate to astropy.nddata. scikit-image was never imported at runtime -- only in the test file, and only for a version-check skip condition that used broken string comparison.

Removed it from runtime deps and cleaned up the test imports.

ccdproc's block_reduce/block_average/block_replicate wrappers
delegate to astropy.nddata -- skimage was never called at runtime.
The version-skip decorators in the test file used broken string
comparison and guarded against an old numpy dev incompatibility
that's astropy's problem now.

Closes astropy#921.
Copy link
Copy Markdown
Member

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @karlhillx -- can you add yourself to the list of contributors or would you like me to do that for you?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.56%. Comparing base (2659867) to head (16dcaa1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #923   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files           8        8           
  Lines        1571     1571           
=======================================
  Hits         1517     1517           
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karlhillx
Copy link
Copy Markdown
Contributor Author

Thanks for the quick fix @karlhillx -- can you add yourself to the list of contributors or would you like me to do that for you?

Done, just pushed a commit adding myself. Thanks Matt!

@mwcraig
Copy link
Copy Markdown
Member

mwcraig commented Jun 3, 2026

Thanks @karlhillx!

@mwcraig mwcraig merged commit c9b8cf3 into astropy:main Jun 3, 2026
12 of 15 checks passed
@karlhillx karlhillx deleted the remove-scikit-image-dep branch June 3, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants