Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #464
A sized custom
showindexrejects valid input whenSEPARATING_LINErows are present because its length is compared with all display rows. A DataFrame's implicit index also shifts separator labels onto subsequent data rows.This change checks sized indices against actual data rows, creates automatic indices with the same count, and filters DataFrame-owned labels alongside separator rows so each data row retains its original label. Explicit list/tuple indices contain one ID per data row; extra IDs previously accepted and silently discarded are now rejected.
The public regressions cover list, tuple, and iterator indices; single and multiple separators, including list-wrapped markers; shorter and longer indices; and DataFrame default/True/always indices. Literal table expectations verify both row labels and separators. Against the original source, 8 of the 11 cases fail and 3 controls pass.
Validation on Windows:
toxextra environments: each 393 passed, 1 skipped.This fix preserves existing iterator length behavior and does not address the separate trailing-separator rendering problem.
AI assistance was used for investigation, implementation, and review. The failures and checks above were executed locally, and the final source received independent reviews before submission.