Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354.
What was wrong
A header that already fits inside an explicit
maxcolwidthslimit still pushed the columnpast that limit: the header-driven minimum column width is
width(header) + MIN_PADDINGand was never compared with the limit. With
maxcolwidths=[None, None, 8]and an8-character header the cell was rendered 12 wide (content 10) instead of 10 (content 8) —
two extra characters per affected column, enough to overflow a terminal when
maxcolwidthsis derived from the terminal width.Minimal reproduction