test: drop the unread reply assignment in the near-miss path loop - #100
Merged
Merged
Conversation
The loop asserts on what reached upstream and on X-Redacted; the reply body was read into text and never checked (CodeQL js/useless-assignment-to-local, alert #22).
github-actions
Bot
added
tests
sprayberry-redline
approved these changes
Sep 27, 2026
sprayberry-redline
left a comment
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: approve. Removes a body read in the near-miss path loop whose result was never asserted on. The remaining assertions use the response headers and the stub's recorded upstream calls, both available once the response resolves, so the loop's coverage is unchanged and it now matches the sibling loop below it. The text variable is still declared and used by the other sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves CodeQL alert #22 (
js/useless-assignment-to-local,_test_proxy.mjs:294).The near-miss path loop asserts that upstream never saw raw PII and that
X-Redacted >= 2. It also read the reply intotextand never checked it. This removes that line.A restore assertion was not added in its place: the echo stub routes on
req.url.includes("/chat/completions"), case-sensitive and undecoded, so it answers/v1/Chat/Completionsand/v1/chat/completion%73with a 404 even though cordon classifies and redacts both. Restore on those paths is a stub question, not something this loop tests.npm test: all suites pass (proxy 115/0).